bugfix: Add Case Insensitive URL Matching for Webpages #502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
A recent bug cropped up where the page https://hiring.careerbuilder.com/portal/ppcaliforniaState300 was not getting the
tables_datafrom Cortex. This was because the URL was saved in cortex ashttps://hiring.careerbuilder.com/portal/PPCaliforniaState300For example:
https://api.cbcortex.com/api/v1/webpages/feed?url=https://hiring.careerbuilder.com/portal/PPCaliforniaState300 is now a 404 because I changed the URL to lowercase.
but this is ok:
https://api.cbcortex.com/api/v1/webpages/feed?url=https://hiring.careerbuilder.com/portal/ppcaliforniastate300
JIRA:
https://cb-content-enablement.atlassian.net/browse/EM-1451
Steps to Take On Prod
n/a
Changes:
Changes to setup
Architectural changes
citextextensionMigrations
bundle exec rake db:migrateLibrary changes
Side effects
Screenshots
Before
After
QA Links:
With Capotalization:
Without:
How to Verify These Changes
Specific pages to visit
Steps to take
http://web.cortex-4.development.c66.meResponsive considerations
Relevant PRs/Dependencies:
n/a
Additional Information
need to run
bundle exec rake db:migratealso this could be alternatively solved just bycontext.params.url.downcasewhich may actually be more performant by a few milliseconds(possibly) .