Skip to content

Conversation

@MKwenhua
Copy link
Contributor

@MKwenhua MKwenhua commented Jun 23, 2017

Purpose:

It seems the version of Redactor's inline styling had a bug when altering highlighted passages. So I fixed this by adding in the version of Redactor that came after the bug fix I found here. I also updated angular-redactor to the latest version and emailed Imperavi for account information(they should get back to us in two days).

Also luckily the last version of Redactor on bower happened to be newer than our current version which also happened to be a few versions after the fix. See here bower-redactor

So inline styling works again.

JIRA:

https://cb-content-enablement.atlassian.net/browse/AR-71

Steps to Take On Prod

n/a

Changes:

  • Changes to setup

    • update bower
  • Architectural changes

    • n/a
  • Migrations

    • n/a
  • Library changes

    • bumped angular-redactor
    • added inline-styles redactor plugin to legacy/vendor
    • used replaced redactor with a slightly newer version from bower
  • Side effects

    • n/a

Screenshots

  • Before
    n/a
  • After
    n/a

QA Links:

http://web.cortex-8.development.c66.me/legacy

How to Verify These Changes

  • Specific pages to visit

    • legacy#/posts/new/article
  • Steps to take

  • Responsive considerations

    • n/a

Relevant PRs/Dependencies:

n/a

Additional Information

@MKwenhua
Copy link
Contributor Author

@toastercup should I wait till the cortex servers are all updated to ES 5.4.x before merging?

@toastercup toastercup force-pushed the AR-71/WYSIWYG-Text-Formatting-Options-Broken branch from 0dbab6d to dc7caf9 Compare July 6, 2017 18:58
@toastercup toastercup force-pushed the AR-71/WYSIWYG-Text-Formatting-Options-Broken branch from dc7caf9 to 0898b85 Compare July 6, 2017 18:59
@toastercup
Copy link
Member

@MKwenhua I struck the elasticsearch-related commits from this branch and rebased with develop, so I'll be merging shortly (once tests pass)

@toastercup toastercup merged commit 1e44a01 into develop Jul 6, 2017
@toastercup toastercup deleted the AR-71/WYSIWYG-Text-Formatting-Options-Broken branch July 6, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants