-
-
Notifications
You must be signed in to change notification settings - Fork 52
docs(cla): sign contributor license agreement #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request adds "cortex@example.com" to the bot allowlist in the CLA check script. As a result, this email will be treated as a bot account and excluded from CLA verification requirements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ❌ 5❌ Failed checks (5 warnings)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @RIVALHIDE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request formally records a new contributor's agreement to the Contributor License Agreement (CLA) for the Cortex Linux project. By adding their signature to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@Anshgrover23 Please Merge this CLA PR |
Anshgrover23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RIVALHIDE I think you need to add it in allowlist, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new signature to the Contributor License Agreement. However, the signature details appear to use placeholder information for the name, GitHub username, and email. This is a high-severity issue that needs to be corrected to ensure the CLA is valid. I've left a specific comment with details.
|
@Anshgrover23 Can you tell me where is allowlist |
Anshgrover23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RIVALHIDE Sorry my bad, to ignore list I mean.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/scripts/cla_check.py (1)
338-351: Critical: This change bypasses CLA verification rather than signing the CLA.The
bot_patternsallowlist is intended for automated systems (dependabot, renovate, codecov, etc.) that are excluded from CLA requirements. Addingcortex@example.comhere causes the CLA check to skip this email entirely (lines 358-366), rather than recording a legitimate CLA signature.This PR is titled as a CLA signature but the actual effect is to circumvent the CLA enforcement mechanism. A human contributor should be added to
.github/cla-signers.jsoninstead, not to the bot allowlist.This change should not be merged as it:
- Undermines the legal protection the CLA provides
- Allows contributions without the contributor actually agreeing to CLA terms
- Misrepresents the intent of the change
To properly sign the CLA, the contributor's information should be added to the
cla-signers.jsonfile under theindividualsarray with their GitHub username and emails, not added to this bot bypass list.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/scripts/cla_check.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Test (Python 3.11)
- GitHub Check: Test (Python 3.12)
- GitHub Check: test (3.11)
- GitHub Check: test (3.12)
- GitHub Check: test (3.10)
|
@Anshgrover23 I have added cortex@example.com in allowlist in cla_check.py can you merge this. |
Anshgrover23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!



Related Issue
Closes #586
Summary
Adding my signature to the Contributor License Agreement (CLA) to enable future contributions to the Cortex Linux project.
Signer Details:
AI Disclosure
Checklist
type(scope): descriptionor[scope] descriptionpytest tests/) - N/A for CLA signatureSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.