-
-
Notifications
You must be signed in to change notification settings - Fork 52
Cla add #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Cla add #652
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
5b20ab8
fix: connect wizard command to FirstRunWizard implementation
668db9e
feat: show API provider menu with key detection indicators
a2186c5
feat(wizard): streamline wizard to only handle API key configuration\…
def8a8f
style: format first_run_wizard.py with black for lint compliance
1b96bd0
Improve cortex wizard UX: auto-detect providers, lazy key validation,…
2b5fefc
Fix linting issues: remove duplicate imports, organize imports, fix w…
5a56769
Format code with Black to fix CI formatting checks
c0c3ce0
Fix tests: update python commands to python3, catch Exception in prov…
9afe27d
Fix remaining CI test failures: update env loading priority, add miss…
f8dff36
Fix API key fallback logic and install test failures
8d13202
Fix cortex wizard OpenAI API key detection regression
2a59781
Fix test_install_no_api_key by adding CommandInterpreter mock
1aafef3
fix(cli): allow install without API key
c4d1a4b
Remove unnecessary _get_api_key mock from test_install_no_api_key
3d12434
Fix ruff linting error: remove whitespace from blank line 521
8b4b8f5
Fix wizard inconsistent behavior across execution contexts
d437c34
Fix ruff linting error: remove whitespace from blank line 336
4ca3a42
Always show provider selection menu and add skip option
d1b3df9
feat: seamless onboarding—auto-create .env from .env.example, improve…
d5f863e
feat(wizard): always show all providers and prompt for blank API keys
43aa134
fix: rename api_key_test.py to api_key_validator.py to prevent pytest…
9b54c87
Fix EOF newline for api_key_validator
4f68679
Fix __all__ and resolve ruff lint errors
6ad2c30
Fix W292: ensure newline at EOF in test_first_run_wizard
8c6ecfa
fix: rename api_key_test to api_key_validator to fix pytest collection
591a931
fix: rename api_key_test to api_key_validator to fix pytest issues
3f6b837
feat: add environment variable manager with encryption and templates
f8a00a9
fix: resolve ruff lint errors and PEP8 issues
050dc82
fix: resolve ruff lint errors and PEP8 issues
b79c04e
fix: connect wizard command to FirstRunWizard implementation
9098738
feat: show API provider menu with key detection indicators
ebabeb1
fix: remove duplicate env subparser and fix env_demo.py
82595c8
fix: remove duplicate CLI subparser definitions
14cf97a
fix: clean up formatting and improve readability in multiple files
0729505
fix: honor shell-exported API keys when .env is empty (#126)
60a4ccb
Merge branch 'main' into fix/cortex-wizard-not-running
jaysurse 716d408
fix: remove duplicate line causing syntax error in cli.py
6a8b0b5
Fix CLI bugs: remove invalid offline param, duplicates, apply black f…
5c2b554
Merge upstream/main into fix/cortex-wizard-not-running
1c09517
fix: resolve linting issues and fix flaky test
a7985d2
Resolve merge conflicts
e50568a
Merge branch 'main' into fix/cortex-wizard-not-running
jaysurse c5ce259
feat: integrate wizard with API key detection
d60a188
fix: rename duplicate test function to avoid linting error
c6d5377
trigger: re-run CI checks
04f7a1d
Merge branch 'main' into fix/cortex-wizard-not-running
Anshgrover23 37d20a5
Merge branch 'main' into fix/cortex-wizard-not-running
Anshgrover23 2b30fdc
Merge branch 'main' into fix/cortex-wizard-not-running
Anshgrover23 c810bb2
Merge branch 'main' into fix/cortex-wizard-not-running
jaysurse dfd7431
fix: resolve syntax errors in cli.py and first_run_wizard.py
366bc2b
Merge branch 'main' into fix/cortex-wizard-not-running
jaysurse 73589b1
chore: add alternate emails to existing CLA signers
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for trying different providers within the
installmethod is quite complex, involving a loop, nested try/except blocks, and manual provider ordering. This functionality could be encapsulated into a dedicated helper function or class (e.g., aProviderFallbackHandler) to simplify theinstallmethod, improve readability, and make the logic more reusable and easier to test independently.