Update grpc-opentracing to latest version at new home#1113
Conversation
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
This makes all use of grpc-ecosystem libraries consistent, and brings in one bug fix "Fix dropped namespace in url parsing (weaveworks/common#128)". Signed-off-by: Bryan Boreham <bryan@weave.works>
|
Are we sure https://github.com/opentracing-contrib/go-grpc is the new home for https://github.com/grpc-ecosystem/grpc-opentracing/tree/master/go/otgrpc? Is there any 'official' decision here? |
|
Issues went ignored in the latter; I found mention of the move somewhere and my PR was merged in the former. |
|
I've sent an email to both communities so see what the latest on this is. |
|
From the gRPC perspective; we're happy to point folks wherever. I'd like to confirm the correct repo with the project maintainers though, and I'm not clear on who that is? |
|
There already is an unmerged PR at grpc-ecosystem/grpc-opentracing#43 |
|
Thanks @Falco20019, that LGTM. |
This is primarily to stop marking cancelled operations as errors - opentracing-contrib/go-grpc#1
Also update weaveworks/common to make all use of grpc-ecosystem libraries consistent, and bring in one bug fix "Fix dropped namespace in url parsing (weaveworks/common#128)".