Underpinnings of a better single-process, no-dependancies Cortex.#1127
Merged
tomwilkie merged 8 commits intocortexproject:masterfrom Dec 4, 2018
Merged
Underpinnings of a better single-process, no-dependancies Cortex.#1127tomwilkie merged 8 commits intocortexproject:masterfrom
tomwilkie merged 8 commits intocortexproject:masterfrom
Conversation
Contributor
Author
|
Also see weaveworks/common#132 |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
This allows us to start Cortex on the Mac. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
…entation as the ring does. Also, remove the two instances of KVClient mock hooks. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
gouthamve
approved these changes
Dec 4, 2018
Contributor
gouthamve
left a comment
There was a problem hiding this comment.
Looks good! Mostly looks like it's just moving the flags package to a new subdir and the updating the references. I'm a little concerned about Linux where the interface name is not one of the defaults. My linux systems have wlp2s0 in my laptop and enp2s0 on my desktop.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Contributor
Author
I've added the ability to override the interface names in yaml; don't want to put |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to do the refactoring needed to build a better local/no-dependancies experience:
eth0anden0so Cortex will start on a Mac.