Skip to content

Allow smaller varbit chunks on read #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bboreham merged 1 commit into from
Dec 1, 2018
Merged

Allow smaller varbit chunks on read #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/chunk/encoding/varbit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func (c *varbitChunk) Slice(_, _ model.Time) Chunk {

// Marshal implements chunk.
func (c varbitChunk) Marshal(w io.Writer) error {
size := c.marshalLen()
size := c.Size()
n, err := w.Write(c[:size])
if err != nil {
return err
Expand Down Expand Up @@ -327,9 +327,6 @@ func (MarshalConfig) RegisterFlags(f *flag.FlagSet) {

// marshalLen returns the number of bytes that should be marshalled for this chunk
func (c varbitChunk) marshalLen() int {
if alwaysMarshalFullsizeChunks {
return cap(c)
}
bits := c.nextSampleOffset()
if bits < varbitThirdSampleBitOffset {
bits = varbitThirdSampleBitOffset
Expand All @@ -351,6 +348,9 @@ func (c varbitChunk) Len() int {
}

func (c varbitChunk) Size() int {
if alwaysMarshalFullsizeChunks {
return cap(c)
}
return c.marshalLen()
}

Expand Down