Parallelise calls from the querier -> ingester in an attempt to reduce latency.#1282
Closed
tomwilkie wants to merge 1 commit intocortexproject:masterfrom
Closed
Parallelise calls from the querier -> ingester in an attempt to reduce latency.#1282tomwilkie wants to merge 1 commit intocortexproject:masterfrom
tomwilkie wants to merge 1 commit intocortexproject:masterfrom
Conversation
…e latency. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
query-stream-parallelism
branch
from
053b888 to
d742759
Compare
Contributor
|
When I look in Jaeger it seems those calls are already parallelised. This change is to make them less parallel? Edit: example showing all calls starting at the same time. |
Contributor
Author
They're parallelised to multiple ingesters, but each ingester only has a single stream. This change gives each ingester multiple streams. Not clear its worth it after #1306 though. And if we did, I'd want to integrate this with the inverted index shards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even after #1233, we're still seeing long tail latencies on QueryStream calls to the ingester. This PR splits calls from the queries to the the ingesters up into a configurable number of parallel calls.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com