Set the default interval for promql to eval subqueries.#1327
Merged
gouthamve merged 1 commit intocortexproject:masterfrom Apr 15, 2019
Merged
Set the default interval for promql to eval subqueries.#1327gouthamve merged 1 commit intocortexproject:masterfrom
gouthamve merged 1 commit intocortexproject:masterfrom
Conversation
Fixes cortexproject#1265 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
bboreham
reviewed
Apr 10, 2019
| f.BoolVar(&cfg.IngesterStreaming, "querier.ingester-streaming", false, "Use streaming RPCs to query ingester.") | ||
| f.IntVar(&cfg.MaxSamples, "querier.max-samples", 50e6, "Maximum number of samples a single query can load into memory.") | ||
| f.DurationVar(&cfg.IngesterMaxQueryLookback, "querier.query-ingesters-within", 0, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") | ||
| f.DurationVar(&cfg.DefaultEvaluationInterval, "querier.default-evaluation-interval", time.Minute, "The default evaluation interval or step size for subqueries.") |
Contributor
There was a problem hiding this comment.
I would slightly prefer this defaults to 15 seconds, but not going to make a big thing of it
Contributor
Author
There was a problem hiding this comment.
The default for it in prometheus is 1m hence I made it 1m here too.
Contributor
There was a problem hiding this comment.
Sticking with Prometheus defaults seems the right thing to do.
bboreham
approved these changes
Apr 10, 2019
Contributor
|
QQ: should this be overridable per user? Or should we cross that bridge when we get there? |
Contributor
Author
|
Well making it per user would make things much more complicated as that would mean changes upstream. Currently the eval interval is a global variable. |
Contributor
Author
|
Merging this as-is as I think we should cross the bridge when we get there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have a subquery of the form
[1h:], the second parameter is substituted to be the default evaluation interval by Prometheus. We don't set that in Cortex.This is a little contentious, because if users change the default in their prometheus, their graphs in local vs cloud would be different.
Fixes #1265