Update weaveworks common#1339
Merged
gouthamve merged 2 commits intocortexproject:masterfrom Apr 24, 2019
Merged
Conversation
added 2 commits
April 22, 2019 13:12
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Author
|
@bboreham PTAL |
Contributor
Author
|
@bboreham should I include this list as part of my commit message? |
bboreham
approved these changes
Apr 22, 2019
Author
|
can this be merged? I don't have merge permissions. |
Contributor
|
It is awaiting a second review as required by our rules I don't need you to change anything, although you might take it as a guide to what is useful to know when reviewing a change. |
gouthamve
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1279