Updated table deletes to ignore empty prefixes#1341
Merged
gouthamve merged 1 commit intocortexproject:masterfrom Apr 29, 2019
Merged
Updated table deletes to ignore empty prefixes#1341gouthamve merged 1 commit intocortexproject:masterfrom
gouthamve merged 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Author
|
@bboreham PTAL |
Author
|
@bboreham can I get your feedback on this? We have to currently run a fork of upstream cortex as without this fix the table manager tries to delete all DynamoDB tables. Thanks! |
bboreham
approved these changes
Apr 25, 2019
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Thanks for this. Would be good to add this case to the test too.
Author
|
@bboreham can you merge this? I will add a second PR with unit tests as you requested but we kind of need this image asap. It turns out the table-manager will not create new tables because of this failure which in turn will cause other failures from querier/ingesters. Thanks! |
gouthamve
approved these changes
Apr 29, 2019
Author
|
Thanks @gouthamve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1340