Put Distributor hash algorithm back the way it was before 922a3b989a#1343
Merged
Put Distributor hash algorithm back the way it was before 922a3b989a#1343
Conversation
Signed-off-by: Bryan Boreham <bryan@weave.works>
Contributor
|
LGTM 👍 |
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
revert-hash-change
branch
from
069c60f to
6c0451a
Compare
khaines
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1306 moved the hash implementation, but at the same time flipped it from FNV-1 to FNV-1a.
Put it back the way it was before, and add some comments noting the difference.
Note: without this, the effect is to re-shard all series to a different ingester, causing a spike in active series and (in shard-by-metric-name mode) breaking queries.