Return an empty iterator when no chunks are present#1355
Closed
gouthamve wants to merge 1 commit intocortexproject:masterfrom
Closed
Return an empty iterator when no chunks are present#1355gouthamve wants to merge 1 commit intocortexproject:masterfrom
gouthamve wants to merge 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
bboreham
reviewed
Apr 30, 2019
| } | ||
|
|
||
| // emptyIterator has no samples. | ||
| type emptyIterator struct{} |
Contributor
There was a problem hiding this comment.
How about using NewNopIterator() from TSDB instead of this?
AFAICS only Batch() would behave differently, and that might indicate a bug.
Contributor
Author
There was a problem hiding this comment.
NewNopIterator() returns a tsdb.Iterator as seen here: https://github.com/prometheus/tsdb/blob/719b57db44f5e5dbad7d813a5645c222c3ba7647/chunkenc/chunk.go#L55-L65
Not sure how it'll be simpler to use that than just add a few lines here.
Contributor
There was a problem hiding this comment.
because then you won't add any lines here?
I'm pretty sure it returns a chunkenc.Iterator, i.e. it fits in curr.
Contributor
|
Closed in favour of #1461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1354