Make sure only series with chunks are sent#1385
Merged
gouthamve merged 2 commits intocortexproject:masterfrom May 13, 2019
Merged
Make sure only series with chunks are sent#1385gouthamve merged 2 commits intocortexproject:masterfrom
gouthamve merged 2 commits intocortexproject:masterfrom
Conversation
Contributor
|
Panic in #1354 seems to be on the chunk store path, not the ingester path. Also, might be easier to put this check in the querier side of this interface, so you can test without rolling new ingesters? |
gouthamve
force-pushed
the
dont-send-empty-series
branch
from
85bc150 to
dce1f47
Compare
Contributor
Author
Not really, https://github.com/cortexproject/cortex/blob/master/pkg/querier/ingester_streaming_queryable.go#L99-L103, the ingester path uses code from that file, but its still the ingester streaming path.
Done. |
gouthamve
force-pushed
the
dont-send-empty-series
branch
from
dce1f47 to
00cdbdc
Compare
tomwilkie
reviewed
May 13, 2019
pkg/ingester/ingester_test.go
Outdated
Contributor
There was a problem hiding this comment.
Lets not commit commented-out code.
Contributor
|
LGTM! |
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
dont-send-empty-series
branch
from
00cdbdc to
d7d4ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could fix #1354