Update k8s manifests with target flags#1398
Merged
csmarchbanks merged 4 commits intocortexproject:masterfrom May 21, 2019
Merged
Update k8s manifests with target flags#1398csmarchbanks merged 4 commits intocortexproject:masterfrom
csmarchbanks merged 4 commits intocortexproject:masterfrom
Conversation
Signed-off-by: unknown <weeco91@gmail.com>
Signed-off-by: unknown <weeco91@gmail.com>
jtlisi
suggested changes
May 18, 2019
Signed-off-by: unknown <weeco91@gmail.com>
khaines
approved these changes
May 20, 2019
csmarchbanks
approved these changes
May 21, 2019
Contributor
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks, and this LGTM! Would you rebase with the current master - it should fix the failing test.
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1262 has been merged, one has to set target flags for each microservice. I updated the k8s manifests to do so.
While doing so I noticed an inconsistency of the target flags.
alertmanagerhad been used while beforehandtable-managerandquery-frontendwere used. Therefore I also updated the alertmanager module name to achieve consistent target flags - before it's too late.