Leave Server module running until end of shutdown#1463
Merged
csmarchbanks merged 2 commits intomasterfrom Jun 12, 2019
Merged
Conversation
We want the process to answer requests (including status and metrics) until it has finished shutting down. Every target depends on Server, so it will get shut down as a dependency. Signed-off-by: Bryan Boreham <bryan@weave.works>
csmarchbanks
approved these changes
Jun 12, 2019
Contributor
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
LGTM, one small comment that I do not feel too strongly about.
pkg/cortex/cortex.go
Outdated
| // Stop gracefully stops a Cortex. | ||
| func (t *Cortex) Stop() error { | ||
| t.server.Shutdown() | ||
| t.stop(t.target) |
Contributor
There was a problem hiding this comment.
I think you can just inline the implementation of t.stop now.
Contributor
Author
There was a problem hiding this comment.
I've done that - it hadn't occurred to me, but it is shorter.
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
stop-server-later
branch
from
39e3c6d to
473b333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1447
We want the process to answer requests (including status and metrics) until it has finished shutting down.
Every target depends on Server, so it will get shut down as a dependency.