Optionally write stub entries to the chunk cache from ingesters#1482
Merged
Optionally write stub entries to the chunk cache from ingesters#1482
Conversation
bboreham
force-pushed
the
chunk-cache-stubs
branch
2 times, most recently
from
d99e415 to
9f9d53b
Compare
csmarchbanks
reviewed
Jul 2, 2019
Contributor
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Generally LGTM, added a couple small comments/questions.
pkg/chunk/chunk_store.go
Outdated
Contributor
There was a problem hiding this comment.
This should only be set on the ingester correct? Would prefixing it with ingester make sense even though it is in the store config?
Contributor
Author
There was a problem hiding this comment.
I see what you're getting at, but not sure about the suggestion.
Yes, it's only supposed to be set when storing chunks, which we only do in the ingester today.
Contributor
There was a problem hiding this comment.
Yeah, I wasn't sure of my suggestion either. I am happy with it as is.
Designed for the case where you don't want to cache every chunk written by ingesters, but you do want to take advantage of chunk write deduplication. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
chunk-cache-stubs
branch
from
9f9d53b to
1afc6b4
Compare
Contributor
Author
|
I renamed the field so it won't be visible in yaml |
csmarchbanks
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This an optional optimisation for #1475 - if we have a dedicated cache just for de-duplicating writes then we don't need to store the chunk data in it, just a placeholder for the key.