Merged
Conversation
Leave the flag and yaml names for now to avoid crashing. Signed-off-by: Bryan Boreham <bryan@weave.works>
jtlisi
approved these changes
Aug 9, 2019
Contributor
jtlisi
left a comment
jtlisi
left a comment
There was a problem hiding this comment.
This looks great to me, I can't think of a case where you wouldn't want the flag enabled.
csmarchbanks
approved these changes
Aug 9, 2019
Contributor
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
I like it. Before we merge though, @jtlisi would this affect the HA ruler in any strange way? I think it uses the lifecycler code at least.
tomwilkie
approved these changes
Aug 12, 2019
Contributor
|
Test failure looks legit? |
Now we default to always attempt a transfer, we need to disable this in testing otherwise it slows every test down by 5-10 seconds. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
remove-claim-on-rollout-flag
branch
from
114faf3 to
6973461
Compare
Contributor
|
Changelog entry? Otherwise merge away. |
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
remove-claim-on-rollout-flag
branch
from
7256e39 to
ea76f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Slack
Leave the flag and yaml names for now to avoid crashing.