fix routing change for alertmanager#1670
Merged
bboreham merged 1 commit intocortexproject:masterfrom Sep 18, 2019
Merged
Conversation
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
bboreham
approved these changes
Sep 16, 2019
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Looks reasonable.
We really really need some tests on alertmanager.
gouthamve
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1597 ended up breaking the routing in the alertmanager. This because the route prefix provided in the function is only meant to be . added to the
v2alertmanager api. In the cortex use case bothv1andv2need to be prefixed with the external url. This pr fixes the issue.Signed-off-by: Jacob Lisi jacob.t.lisi@gmail.com