Reuse request timeseries slice on error in the ingester#1863
Closed
pracucci wants to merge 1 commit intocortexproject:masterfrom
Closed
Reuse request timeseries slice on error in the ingester#1863pracucci wants to merge 1 commit intocortexproject:masterfrom
pracucci wants to merge 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Contributor
|
Which kinds of error did you have in mind? |
Contributor
Author
|
You're right. Re-checking the code, soft errors (like out of order timestamp) did reuse the slice, so slices were not reused only in case of hard errors, which are hard. Closing it, thanks for pointing out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
If I'm not missing anything, this should be a safe change to do, to make sure a request timeseries slice gets reused (in the ingester) even in case of error.
Which issue(s) this PR fixes:
No issue
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]