Skip to content

Added user ID to ingester push soft/hard errors#1960

Merged
gouthamve merged 1 commit intocortexproject:masterfrom
pracucci:add-user-id-to-ingester-errors
Jan 7, 2020
Merged

Added user ID to ingester push soft/hard errors#1960
gouthamve merged 1 commit intocortexproject:masterfrom
pracucci:add-user-id-to-ingester-errors

Conversation

@pracucci
Copy link
Contributor

@pracucci pracucci commented Jan 7, 2020

What this PR does:
Today I was investigating the cause of the error sample with repeated timestamp but different value for series and I couldn't find the related user because it's not logged. In this PR, I'm suggesting to wrap any ingester Push error with the user ID.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouthamve gouthamve merged commit f01fd63 into cortexproject:master Jan 7, 2020
@pracucci pracucci deleted the add-user-id-to-ingester-errors branch January 8, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants