Updated Thanos to introduce the new block meta fetcher#1970
Merged
gouthamve merged 6 commits intocortexproject:masterfrom Feb 4, 2020
Merged
Updated Thanos to introduce the new block meta fetcher#1970gouthamve merged 6 commits intocortexproject:masterfrom
gouthamve merged 6 commits intocortexproject:masterfrom
Conversation
Contributor
Author
|
@jtlisi I've done a change in the ruler, to fix it after the changes done in this Prometheus PR prometheus/prometheus#6455 (it took me a while to figure out the root cause). May you take a look if looks good to you? |
jtlisi
approved these changes
Jan 18, 2020
Contributor
jtlisi
left a comment
jtlisi
left a comment
There was a problem hiding this comment.
LGTM
I finally got around to testing this today. Changes to the ruler are 👍
Contributor
Author
|
@bboreham @gouthamve May you at a look you too, please? Would allow us to move forward with the TSDB blocks storage, taking advantage of new features introduced in Thanos. |
pracucci
force-pushed
the
update-thanos
branch
from
9072cd6 to
cca2ec2
Compare
Contributor
Author
|
@pstibrany Could you also review it, in particular the metrics collected from |
pstibrany
approved these changes
Jan 22, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Looks good to me, including metrics.
pracucci
force-pushed
the
update-thanos
branch
4 times, most recently
from
e524aae to
34af826
Compare
jtlisi
added a commit
to grafana/cortex
that referenced
this pull request
Jan 30, 2020
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
update-thanos
branch
from
49ae2bf to
7787ff2
Compare
gouthamve
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
I've recently updated Thanos (and dependencies) in the PR #1935. In the meanwhile Thanos introduced the block meta fetcher, which I would like to get into, so I'm submitting another PR to upgrade Thanos again.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]What has changed
Other than Thanos and Prometheus, the following dependencies have changed. No breaking changes have been found.
According to the changelog and looking at the changeset, the upgrade shouldn't affect us:
Looking at the changeset, the
Ping()API has been added to the client. No other change.