Comment unsafe memory usage in ingester push path#2004
Merged
Conversation
pstibrany
approved these changes
Jan 20, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
These are great and useful comments for future reviewers!
Contributor
Author
|
See #2006 |
bboreham
force-pushed
the
comment-unsafe-labels
branch
2 times, most recently
from
0e897dc to
d52556a
Compare
Signed-off-by: Bryan Boreham <bryan@weave.works>
…data Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
comment-unsafe-labels
branch
from
d52556a to
e31ea09
Compare
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is roughly what I was suggesting at #2000 to warn future maintainers.
I have left (what I assume is) the bug unchanged.I have changed the way errors are wrapped to make it clearer how we avoid retaining references to unsafe data inside errors.