Fix flaky tests in compactor#2018
Merged
pracucci merged 1 commit intocortexproject:masterfrom Jan 24, 2020
Merged
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
sandeepsukhani
approved these changes
Jan 23, 2020
| compactorCfg.retryMinBackoff = 0 | ||
| compactorCfg.retryMaxBackoff = 0 | ||
|
|
||
| bucketClient := &cortex_tsdb.BucketClientMock{} |
Contributor
There was a problem hiding this comment.
Changes look good to me but I am trying to understand how this was causing tests to fail intermittently since it was still created before calling newCompactor down below. Anything I am missing to see here?
Contributor
Author
There was a problem hiding this comment.
It was created before newCompactor() but mocked later (after the prepare() exits).
Contributor
There was a problem hiding this comment.
Right, my bad. Changes look more relevant for this block
Thanks!
codesome
approved these changes
Jan 24, 2020
tomwilkie
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #1942 I did a mistake in the compactor tests which cause some flaky tests. The compactor tests mock the bucket client after the compactor is started and this leads to flaky tests (unfrequent, but seen in CI). This PR fixes it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]