add per-tenant alertmanager metrics#2124
add per-tenant alertmanager metrics#2124jtlisi merged 7 commits intocortexproject:masterfrom jtlisi:20200211_pertenant_am_metrics
Conversation
|
@pracucci I paired down the number of user metrics considerably. The ones that remain convey either essential basic information about the number of alerts/silences or help users avoid silent failures.
I also made sure to remove the unused functions I added to |
pstibrany
left a comment
There was a problem hiding this comment.
I have left some comments around metrics code.
pkg/alertmanager/alertmanager.go
Outdated
There was a problem hiding this comment.
Why isn't exposed, while Pause() is? I think it should be specular to Pause() and being exposed too.
pkg/alertmanager/multitenant.go
Outdated
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Moved from #2116 because integration tests don't work for Grafana org repo PRs due to
NOQUAYbeing set as an environment variable.What this PR does:
This PR takes advantage of the
util.MetricFamiliesPerUserstruct to provide per-tenant Alertmanager metrics.Which issue(s) this PR fixes:
Fixes #1631
Checklist
CHANGELOG.mdupdated