Register a histogram that was omitted#2138
Merged
Conversation
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
register-collectors
branch
from
f7ac4b9 to
d490443
Compare
bboreham
changed the title
bboreham
changed the title
pracucci
approved these changes
Feb 17, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM!
Unrelated from this bugfix, we should (actually we slowly are) move away from globally defined metrics to avoid config DB metrics are exposed also when it's not running (ie. microservices deployments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Put back a metric that got lost in #1571.
Note I used
promautofor shorter diff but mostHistogramCollectors in the code registered viainit()functions. It's kinda relying on an implementation detail butdistributor.gois already doing it and yolo.Checklist
CHANGELOG.mdupdated