Fix pushes when ingesters don't have a zone.#2357
Merged
gouthamve merged 3 commits intocortexproject:masterfrom Mar 30, 2020
Merged
Fix pushes when ingesters don't have a zone.#2357gouthamve merged 3 commits intocortexproject:masterfrom
gouthamve merged 3 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Contributor
|
Thanks; I expected the backwards-compatibility test to catch this, but it runs with replication factor 1. |
bboreham
reviewed
Mar 30, 2020
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
pracucci
approved these changes
Mar 30, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
👍 Thanks for fixing it!
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Contributor
|
Indeed thanks for addressing this scenario! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2356