Generalise Modules Service to make it extensible#2559
Generalise Modules Service to make it extensible#2559pstibrany merged 15 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Thanks for your work! I've left some comments, please take a look.
jtlisi
left a comment
jtlisi
left a comment
There was a problem hiding this comment.
Once the rename PR is merged I will give this another pass.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
jtlisi
left a comment
jtlisi
left a comment
There was a problem hiding this comment.
This looks close to ready, just needs some cleanup to make sure CICD is passing.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
This PR also changes wrapping part (all modules are wrapped), so it cannot be merged until Server module can work with that. |
|
@pstibrany - Looks like your changes to signal handling on |
#2576 implements this. |
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
| assert.NotNil(t, svcs) | ||
| assert.NoError(t, err) | ||
|
|
||
| svcs, err = mm.InitModuleServices("service_unknown") |
There was a problem hiding this comment.
This test is interesting because it calls InitModuleServices twice... it's not clear from documentation what should actually happen in that case!
Would you mind adding a test for missing dependency too?
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
LGTM. I've left a small comment about test, but we can always improve that later.
|
Thanks! I'll send a follow up PR for the test. |
3 participants
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Implementation of the generalise module service design doc.
Which issue(s) this PR fixes:
Fixes #2291
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]