Add metric to monitor cert expiry time#2592
Closed
annanay25 wants to merge 2 commits intocortexproject:masterfrom
Closed
Add metric to monitor cert expiry time#2592annanay25 wants to merge 2 commits intocortexproject:masterfrom
annanay25 wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Contributor
|
There are tools for this already, why have it in Cortex? |
pstibrany
reviewed
May 14, 2020
| caCertPool = x509.NewCertPool() | ||
| caCertPool.AppendCertsFromPEM(caCert) | ||
| if len(clientCert.Certificate) > 0 && caCertPool != nil { | ||
| prometheus.MustRegister(tlsCertNotAfterTimestamp) |
Contributor
There was a problem hiding this comment.
Please use new promauto package and give it a registrerer.
Contributor
There was a problem hiding this comment.
It's not even correct register it here, because if the GetTLSConfig() is called twice, it will panic because of a double registration. You can just use promauto.NewGaugeVec() above, even if we should stop using the global prometheus registerer, but if you really want this metric then using the global registry is the easiest option given the current design.
Contributor
|
I'm closing this for now since the general consensus is an external tool should be used to monitor this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds metric to monitor TLS client cert expiry time.
Which issue(s) this PR fixes:
Follow up from #2502
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]Signed-off-by: Annanay annanayagarwal@gmail.com