Conversation
pkg/chunk/encoding/factory.go
Outdated
There was a problem hiding this comment.
Why are you saying it was unused? Being the default true doesn't it mean it's always used unless explicitly disabled via CLI flag?
There was a problem hiding this comment.
Yes, it was written this way to avoid changing things for existing users.
I mean the option to disable was never used.
There was a problem hiding this comment.
However I got the change wrong.
There was a problem hiding this comment.
Yes, then we need to remove the flag while always keeping it enabled ;)
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
c23ce13 to
4a00949
Compare
CHANGELOG.md
Outdated
|
|
||
| * [CHANGE] Query Frontend now uses Round Robin to choose a tenant queue to service next. #2553 | ||
| * [CHANGE] `-promql.lookback-delta` is now deprecated and has been replaced by `-querier.lookback-delta` along with `lookback_delta` entry under `querier` in the config file. `-promql.lookback-delta` will be removed in v1.4.0. #2604 | ||
| * [CHANGE] Removed `-store.fullsize-chunks` option which was undocumented and unused (it broke ingester hand-overs). |
There was a problem hiding this comment.
Would you mind adding the PR number at the end of the line? The release script we use look for PRs missing in the CHANGELOG (for manual check) and does the check based on the PR number here.
gouthamve
left a comment
gouthamve
left a comment
There was a problem hiding this comment.
LGTM but needs rebasing and DCO.
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
f1f926b to
856112c
Compare
It broke ingester hand-overs, and is not needed now we use BigChunk. I left in the code which allows non-full-size chunks to be read in: maybe someone has some in a database. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
856112c to
77f5a1d
Compare
3 participants
It broke ingester hand-overs, and is not needed now we use BigChunk.
Fixes #1163
Checklist
CHANGELOG.mdupdated