Use fnv32a hash for user_subring#2887
Merged
pracucci merged 2 commits intocortexproject:masterfrom Jul 16, 2020
Merged
Conversation
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
pstibrany
approved these changes
Jul 16, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Thank you.
(As a side-note, I would be happy to see removal of this fnv.go copy entirely, and just using stdlib hashing functions.)
pracucci
approved these changes
Jul 16, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Impeccable PR. Well done and thanks! 👏 ❤️
Signed-off-by: Marco Pracucci <marco@pracucci.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #2757
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]