Filter equality matchers on the dynamo side#402
Merged
Conversation
Contributor
|
What's the difference between this & #400? |
aaron7
changed the title
Contributor
Author
|
We cannot filter the value using |
Contributor
|
I think you need one of these: http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Query.html#Query.FilterExpression |
aaron7
changed the title
jml
approved these changes
Apr 21, 2017
Contributor
jml
left a comment
jml
left a comment
There was a problem hiding this comment.
Looks good. One suggestion. Please feel free to merge after addressing it (assuming tests are green).
chunk/aws_storage_client_test.go
Outdated
Contributor
There was a problem hiding this comment.
Probably best to log a warning if we get a FilterExpression that is not supported, rather than silently skipping. Will probably save someone from a frustrating debugging session later.
aaron7
force-pushed
the
398-filter-labels-server-side-dynamodb
branch
from
ddb6e70 to
6cf3480
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398
Created some extra tests for the aws storage client and started filtering by range key.
Added simple field to IndexEntry which is then used to add the filter condition to dynamo if it exists
Tested locally with
http_requests_total{job="cortex/ingester"}Reverted change: #400