Adding AlertManager SNS Receiver Implementation#4382
Adding AlertManager SNS Receiver Implementation#4382pracucci merged 1 commit intocortexproject:masterfrom
Conversation
8ba3b93 to
7d82ad6
Compare
7d82ad6 to
9b3a3a8
Compare
treid314
left a comment
There was a problem hiding this comment.
Thanks! LGTM, Can you changelog entry to be with the other features to stick to format?
9b3a3a8 to
2cdd22a
Compare
|
Done and rebased! :D |
|
Can you please also review this PR @alolita @Aneurysm9? |
bboreham
left a comment
There was a problem hiding this comment.
Thanks! Couple of asks before merge:
Please fix the conflict (formatting in CHANGELOG), and also call out the update to Prometheus alertmanager code in the PR description.
Check what else gets picked up by the update - e.g. were there any major bug-fixes or deprecations in alertmanager between the old and new commits.
dd96a1e to
fe4e7c0
Compare
Signed-off-by: Alan Protasio <approtas@amazon.com>
fe4e7c0 to
852129e
Compare
|
Thanks @bboreham |
treid314
left a comment
There was a problem hiding this comment.
Thanks for adding the changes in Alertmanager to the PR!
Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
What this PR does:
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]