grab reason label from cortex_alertmanager_notifications_failed_total metric#5403
Closed
krishnateja325 wants to merge 2 commits intocortexproject:masterfrom
Closed
grab reason label from cortex_alertmanager_notifications_failed_total metric#5403krishnateja325 wants to merge 2 commits intocortexproject:masterfrom
krishnateja325 wants to merge 2 commits intocortexproject:masterfrom
Conversation
… metric Signed-off-by: Krishna Teja Puttagunta <krishnateja325@gmail.com>
krishnateja325
force-pushed
the
snx5XXFiltering_2
branch
from
c002c1e to
3108f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add reason label to cortex_alertmanager_notifications_failed_total for filtering clientError and serverError.
This includes prometheus/alertmanager#3094 for filtering 5xx Errors in numTotalFailedNotifications metric.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]