AlertManager: include reason label in cortex_alertmanager_notifications_failed_total#5409
Merged
yeya24 merged 1 commit intocortexproject:masterfrom Jun 15, 2023
Merged
Conversation
krishnateja325
force-pushed
the
am_5xx_filtering
branch
from
7abb0df to
c73b814
Compare
…ns_failed_total Signed-off-by: Krishna Teja Puttagunta <krishnateja325@gmail.com>
krishnateja325
force-pushed
the
am_5xx_filtering
branch
from
c73b814 to
e9d6c31
Compare
yeya24
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add reason label to cortex_alertmanager_notifications_failed_total for filtering clientError.
This includes prometheus/alertmanager#3094 for filtering 5xx Errors in numTotalFailedNotifications metric.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]