add fetch timeout when fetching from expanded postings cache #7185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
expanded-posting-cache-fetch-timeout
branch
from
9154279 to
e1c1a5b
Compare
danielblando
approved these changes
Jan 6, 2026
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
yeya24
force-pushed
the
expanded-posting-cache-fetch-timeout
branch
from
e1c1a5b to
4e4edbe
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The current expanded postings cache in Ingester uses context background when fetching postings. This means that the Ingester will keep fetching postings until finish. This changes the behavior before the introduction of expanded postings cache as before Ingester queries will cancel after the configured query timeout.
To avoid fetching postings call running for too long due to very expensive regex queries and causing Ingester CPU issues for too long, this PR tries to introduce a fetch postings timeout to cancel the postings fetch earlier instead of running it forever.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]