Merged
Conversation
friedrichg
force-pushed
the
upgrade-alertmanager-31
branch
2 times, most recently
from
db6114a to
3826076
Compare
friedrichg
commented
Feb 16, 2026
| } | ||
| } else if strings.Contains(t.PkgPath(), "alertmanager/config") && | ||
| strings.HasSuffix(t.Name(), "Config") { | ||
| // Unhandled config type - fail to ensure we don't miss new types. |
Member
Author
There was a problem hiding this comment.
We were missing configuration types before. We want to make sure they are all validated in the future after upgrades
friedrichg
commented
Feb 16, 2026
| if cfg.BasicAuth != nil && cfg.BasicAuth.PasswordFile != "" { | ||
| return errPasswordFileNotAllowed | ||
| } | ||
| if cfg.BasicAuth != nil && cfg.BasicAuth.UsernameFile != "" { |
Member
Author
There was a problem hiding this comment.
This check was missing.
friedrichg
requested review from
CharlieTLe,
SungJin1212,
alanprot,
danielblando and
yeya24
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
force-pushed
the
upgrade-alertmanager-31
branch
from
3826076 to
d911ea3
Compare
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Upgrade alertmanager to v0.31.1
Continues #7221
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]