Update vendoring and common; Allow the AWS backend to get credentials from its environment.#898
Conversation
|
Tested, works like a charm. |
b3105cd to
f504be5
Compare
|
Had to fiddle with dep, and upgrade to 0.5.0, as client_golang, weaveworks/common and uber/jaeger-lib were conflicting. |
|
@bboreham PTAL |
Gopkg.toml
Outdated
There was a problem hiding this comment.
Why? I would expect master to be the default in a repo with no releases.
There was a problem hiding this comment.
Had to fiddle with dep, and upgrade to 0.5.0, as client_golang, weaveworks/common and uber/jaeger-lib were conflicting.
There was a problem hiding this comment.
What I need here, in the file, is the reason for the constraint, and the conditions under which it can be removed.
There was a problem hiding this comment.
I've just tried removing it and everything else stays the same.
|
Please update the PR title and description to include all the material changes. |
|
Since I want to update common too, I rebased and tweaked this. The changes are:
|
|
Hmm, I thought GitHub would pick up my branch in this PR - master...aws-sts |
|
@tomwilkie let me know if you'd like me to push the rebase to your branch |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
|
Sorry for the delay @bboreham; I didn't realise you wanted the change list from weaveworks/common too! I've also removed the constraint you identified as superfluous and rebased. |
|
I've updated the vendored Prometheus to bring in prometheus/prometheus#4436, better tracing spans in PromQL. This required a bunch of updates to vendored k8s, and some minor modifications. |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
If you give the VMs the right instance profile/role, they can authenticate to DynamoDB without having credentials on the command line.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com