Skip to content

Remove v7 & v8 deprecated schemas.#958

Merged
tomwilkie merged 1 commit intocortexproject:masterfrom
grafana:remove-schemas
Aug 30, 2018
Merged

Remove v7 & v8 deprecated schemas.#958
tomwilkie merged 1 commit intocortexproject:masterfrom
grafana:remove-schemas

Conversation

@tomwilkie
Copy link
Contributor

@tomwilkie tomwilkie commented Aug 24, 2018

As discussed in the community call ~a month ago. Removed the flags as well, so the jobs won't start if you are using these schemas.

Fixes #876

Signed-off-by: Tom Wilkie tom.wilkie@gmail.com

@tomwilkie tomwilkie force-pushed the remove-schemas branch 2 times, most recently from ab0e50e to 952e3b9 Compare August 24, 2018 16:30
@bboreham
Copy link
Contributor

Perhaps you mean v7 and v8 ?

@tomwilkie tomwilkie changed the title Remove v6 & v7 deprecated schemas. Remove v7 & v8 deprecated schemas. Aug 24, 2018
cboggs
cboggs previously approved these changes Aug 27, 2018
@cboggs cboggs dismissed their stale review August 27, 2018 13:54

Oops, two tabs, wrong one here. Sorry!

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tomwilkie
Copy link
Contributor Author

Going to hold off merging until #946 is in, as they clash.

As discussed in the community call ~a month ago.  Removed the flags as well, so the jobs won't start if you are using these schemas.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
@tomwilkie tomwilkie merged commit f9de1ca into cortexproject:master Aug 30, 2018
@tomwilkie tomwilkie deleted the remove-schemas branch August 30, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants