Tweak histograms and traces#972
Closed
tomwilkie wants to merge 5 commits intocortexproject:masterfrom
Closed
Conversation
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
…wrong. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Contributor
|
LGTM, based on just the last 2 commits. |
Contributor
|
LGTM as well, but there is a merge conflict that needs resolving first. |
Contributor
|
This makes me happy, once the batch lookups are merged. |
Contributor
Author
|
I've moved this changes on to #981 as they depend on the code there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the histogram buckets for the query path so they're not crazy wrong, and don't trace every cache lookup, thats too many - just trace the aggregate call to the cache.
Includes #971, thats needs merging and reviewing first.