DC-3562 Integration tests for DataApiV1Sdk.get#62
Merged
oleksii-symon-corva-ai merged 11 commits intofeature/api20from May 23, 2022
Merged
DC-3562 Integration tests for DataApiV1Sdk.get#62oleksii-symon-corva-ai merged 11 commits intofeature/api20from
DataApiV1Sdk.get#62oleksii-symon-corva-ai merged 11 commits intofeature/api20from
Conversation
finomayato
reviewed
May 17, 2022
finomayato
left a comment
finomayato
left a comment
There was a problem hiding this comment.
Somehow we get so many changes in tests/makefiles, at the same time we changed so little in an actual app. Why so?
oleksii-symon-corva-ai
changed the title
DataApiV1SdkDataApiV1Sdk.get
Contributor
Author
|
ville
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
DataApiV1Sdk.getneed integrations tests to be reliable.Changes
Added integration tests for
DataApiV1Sdk.getmethod.JIRA ticket
TODO