DC-3567 Add PUT data/{provider}/{dataset}/{id}/ to DataApiV1Sdk#64
Merged
oleksii-symon-corva-ai merged 24 commits intofeature/api20from Jun 7, 2022
Merged
Conversation
oleksii-symon-corva-ai
requested review from
corva-alex-s,
finomayato,
tsilevych and
ville
…add-replace-document-to-data-sdk
# Conflicts: # setup.cfg # src/corva/api_adapter.py # tests/integration/test_api.py
…add-replace-document-to-data-sdk
…add-replace-document-to-data-sdk
finomayato
reviewed
May 23, 2022
| Updated document. | ||
| """ | ||
|
|
||
| response = self.http.put(url=f"data/{provider}/{dataset}/{id_}/", json=document) |
There was a problem hiding this comment.
is it technically possible for one company provide company name of another company and replace their document?
Contributor
Author
There was a problem hiding this comment.
This is regulated by permissions of the company making the request. As far as I know company A can request access to read some dataset of company B.
There was a problem hiding this comment.
so, it should be technically possible within the sdk and "permission regulating" part is in place in data-api. Correct?
Contributor
Author
There was a problem hiding this comment.
Correct
Base automatically changed from
feature/dc-3564_add-post-documents
to
feature/api20
May 23, 2022 12:33
…t-to-data-sdk # Conflicts: # setup.cfg # src/corva/api_adapter.py # tests/integration/test_api.py
Contributor
Author
|
@ville @corva-alex-s @tsilevych please review |
Contributor
Author
|
@ville @corva-alex-s @tsilevych @finomayato please review |
corva-alex-s
approved these changes
Jun 7, 2022
oleksii-symon-corva-ai
deleted the
feature/dc-3567_add-replace-document-to-data-sdk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Users need convenient way to access PUT
data/{provider}/{dataset}/{id}/data API endpoint.Changes
Added PUT
data/{provider}/{dataset}/{id}/toDataApiV1Sdk.JIRA ticket
TODO