fix: change how we generate start/end times for ScheduledDataTime events if merge_events param is True#97
Merged
corva-alex-s merged 4 commits intomasterfrom Apr 17, 2025
Conversation
…nts if merge_events param is True
tsilevych
approved these changes
Apr 16, 2025
corva-alex-s
deleted the
DIR-12-be-python-sdk-spike-check-if-there-is-a-problem-in-merge-events-functionality-for-scheduled-apps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
When merge_events param is used for scheduled "data time" apps we're merging event times of events. This logic was not accurate, in the end our "start_time" and "end_time" were using values from the first event, instead of "start of first -> start of last" like it should be.
Changes
changed logic of generating start/end times for ScheduledDataTime events if merge_events param is True
JIRA ticket
TODO