feat: allow aliases to be skipped in resource definitions #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to "hide" from `get` commands some resources unless they are called by the full name. See siderolabs/talos#10666 Also rekres and bump deps, fix linting issues. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
commented
Apr 16, 2025
| spec.Aliases = append(spec.Aliases, strings.ToLower(spec.DisplayType)) | ||
|
|
||
| spec.AllAliases = append(spec.AllAliases, strings.ToLower(name)) | ||
| if !spec.SkipAutomaticAliases { |
Member
Author
There was a problem hiding this comment.
this is the actual change 🤦♂️
frezbo
approved these changes
Apr 16, 2025
Member
Author
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 16, 2025
We have now two `MountStatus` resources: one legacy under `runtime`, and another (new one) under `block`. As the old `MountStatus` is still used e.g. in Omni, we still keep it around. In order to fix `talosctl get mountstatus` to be non-ambigious, we suppress aliases for the legacy resource: ``` talosctl get mountstatus NODE NAMESPACE TYPE ID VERSION SOURCE TARGET FILESYSTEM VOLUME 172.20.0.2 runtime MountStatus /etc/cni 2 /etc/cni none /etc/cni 172.20.0.2 runtime MountStatus /etc/kubernetes 2 /etc/kubernetes none /etc/kubernetes ``` Fixes siderolabs#10666 See cosi-project/runtime#588 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 22, 2025
We have now two `MountStatus` resources: one legacy under `runtime`, and another (new one) under `block`. As the old `MountStatus` is still used e.g. in Omni, we still keep it around. In order to fix `talosctl get mountstatus` to be non-ambigious, we suppress aliases for the legacy resource: ``` talosctl get mountstatus NODE NAMESPACE TYPE ID VERSION SOURCE TARGET FILESYSTEM VOLUME 172.20.0.2 runtime MountStatus /etc/cni 2 /etc/cni none /etc/cni 172.20.0.2 runtime MountStatus /etc/kubernetes 2 /etc/kubernetes none /etc/kubernetes ``` Fixes siderolabs#10666 See cosi-project/runtime#588 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit e51a8ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to "hide" from
getcommands some resources unless they are called by the full name.See siderolabs/talos#10666
Also rekres and bump deps, fix linting issues.