Charge Trapping apps #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger does chi-squared step
…o filtering before pairing to save time
…essages" This reverts commit d659b27.
…parameters unavailable
Collaborator
|
There is an issue with TFitResultPtr when a fit is empty which causes the program to crash (Sean calls ->IsEmpty() at various places, but this is attempting to access a pointer which doesn't exists and it throws an error and seg faults). I will merge this now, but make a new pull request with the necessary changes to fix this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuclearizer apps which determine charge trapping correction parameters. One app will take in Am241 illumination data for both sides of the detector, and will separately determine the charge loss parameters on the HV side and the LV side. The other app will take in any dataset and maximize symmetry in HV/LV energy ratio vs. CTD space in order to determine charge loss parameters for one side of the detector while the parameters for the other side remain frozen. The Am241 app will be useful for laboratory calibrations to determine the state of charge trapping before launch, and the symmetry-maximizing app will be useful for ongoing calibration of hole-trapping throughout the mission.