[DEE] Read detector dimensions from the geometry #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
commented
Dec 4, 2025
Collaborator
|
I think this is OK for now. |
Author
|
Can we merge this PR or should I add a TODO somewhere first and/or open an issue about this? |
Collaborator
|
It's this: |
ckierans
pushed a commit
to ckierans/nuclearizer
that referenced
this pull request
Dec 10, 2025
* Set the geometry in SMEX DEE SubModules * Read detector dimensions from the geometry * Read detector radius from geometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
MSubModuleChargeTransportall at once became kind of chaotic, so I will be splitting my PR into smaller PRs, which should make it way easier to review and to collect feedback for the individual steps.In this PR, I'm replacing the hard-coded values for strip pitches, detector width, number of strips etc. by the numbers obtained from
MModule::m_Geometry, which I had to pass down toMSubModuleChargeTransport.I will mark the parts of the codes where I have questions/comments after opening the PR.