Skip to content

chore(ci): disable branch coverage for now#500

Merged
seqre merged 2 commits intomasterfrom
stable-coverage
Mar 2, 2026
Merged

chore(ci): disable branch coverage for now#500
seqre merged 2 commits intomasterfrom
stable-coverage

Conversation

@m4tx
Copy link
Member

@m4tx m4tx commented Mar 1, 2026

We've pinned the Rust nightly to a specific version, because it caused some problems when generating the coverage. Seems like the issue hasn't been fixed yet, while a newer nightly version introduced some formatter changes, so it's difficult to stay on the pinned version any longer.

This disables the nightly-only branch coverage calculation and upgrades the Rust nightly version in the CI.

Relevant issues:

Copilot AI review requested due to automatic review settings March 1, 2026 18:06
@github-actions github-actions bot added the A-ci Area: CI (Continuous Integration) label Mar 1, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rust CI workflow to stop computing nightly-only branch coverage (due to upstream LLVM/cargo-llvm-cov issues) and unpins/upgrades the Rust nightly used elsewhere in CI to a newer snapshot.

Changes:

  • Update the pinned Rust nightly toolchain version to nightly-2026-02-28.
  • Switch the coverage job to use the stable toolchain instead of nightly.
  • Remove --branch from cargo llvm-cov commands to disable branch coverage generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@m4tx m4tx force-pushed the stable-coverage branch from 3368f7f to 9dec833 Compare March 1, 2026 18:09
@github-actions
Copy link

github-actions bot commented Mar 1, 2026

🐰 Bencher Report

Branchstable-coverage
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
4,630.60 µs
(-21.68%)Baseline: 5,912.69 µs
7,018.51 µs
(65.98%)
json_api/json_api📈 view plot
🚷 view threshold
883.04 µs
(-13.43%)Baseline: 1,020.02 µs
1,162.74 µs
(75.94%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
801.26 µs
(-14.81%)Baseline: 940.50 µs
1,067.05 µs
(75.09%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
781.51 µs
(-13.28%)Baseline: 901.17 µs
1,025.37 µs
(76.22%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
15,185.00 µs
(-13.19%)Baseline: 17,492.42 µs
20,659.90 µs
(73.50%)
🐰 View full continuous benchmarking report in Bencher

@m4tx m4tx force-pushed the stable-coverage branch from 9dec833 to cd4b27f Compare March 1, 2026 18:18
@github-actions github-actions bot added the C-lib Crate: cot (main library crate) label Mar 1, 2026
We've pinned the Rust nightly to a specific version, because it caused
some problems when generating the coverage. Seems like the issue hasn't
been fixed yet, while a newer nightly version introduced some formatter
changes, so it's difficult to stay on the pinned version any longer.

This disables the nightly-only branch coverage calculation and upgrades
the Rust nightly version in the CI.

Relevant issues:
* llvm/llvm-project#119558
* taiki-e/cargo-llvm-cov#8
@m4tx m4tx force-pushed the stable-coverage branch from cd4b27f to f97f7b2 Compare March 1, 2026 21:46
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 90.00% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once formatting is fixed

@m4tx
Copy link
Member Author

m4tx commented Mar 2, 2026

LGTM once formatting is fixed

@seqre the CI is green, though?

@seqre
Copy link
Member

seqre commented Mar 2, 2026

@seqre the CI is green, though?

I'm confused, how is cot/src/lib.rs fine here, but the same change is failed in other PR???

@m4tx
Copy link
Member Author

m4tx commented Mar 2, 2026

@seqre the CI is green, though?

I'm confused, how is cot/src/lib.rs fine here, but the same change is failed in other PR???

As per this PR's description:

while a newer nightly version introduced some formatter changes, so it's difficult to stay on the pinned version any longer.

@seqre seqre merged commit 41a8830 into master Mar 2, 2026
42 checks passed
@seqre seqre deleted the stable-coverage branch March 2, 2026 18:02
@cotbot cotbot bot mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI (Continuous Integration) C-lib Crate: cot (main library crate)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants