Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust CI workflow to stop computing nightly-only branch coverage (due to upstream LLVM/cargo-llvm-cov issues) and unpins/upgrades the Rust nightly used elsewhere in CI to a newer snapshot.
Changes:
- Update the pinned Rust nightly toolchain version to
nightly-2026-02-28. - Switch the coverage job to use the stable toolchain instead of nightly.
- Remove
--branchfromcargo llvm-covcommands to disable branch coverage generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Branch | stable-coverage |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 4,630.60 µs(-21.68%)Baseline: 5,912.69 µs | 7,018.51 µs (65.98%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 883.04 µs(-13.43%)Baseline: 1,020.02 µs | 1,162.74 µs (75.94%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 801.26 µs(-14.81%)Baseline: 940.50 µs | 1,067.05 µs (75.09%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 781.51 µs(-13.28%)Baseline: 901.17 µs | 1,025.37 µs (76.22%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 15,185.00 µs(-13.19%)Baseline: 17,492.42 µs | 20,659.90 µs (73.50%) |
We've pinned the Rust nightly to a specific version, because it caused some problems when generating the coverage. Seems like the issue hasn't been fixed yet, while a newer nightly version introduced some formatter changes, so it's difficult to stay on the pinned version any longer. This disables the nightly-only branch coverage calculation and upgrades the Rust nightly version in the CI. Relevant issues: * llvm/llvm-project#119558 * taiki-e/cargo-llvm-cov#8
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@seqre the CI is green, though? |
I'm confused, how is |
As per this PR's description:
|
We've pinned the Rust nightly to a specific version, because it caused some problems when generating the coverage. Seems like the issue hasn't been fixed yet, while a newer nightly version introduced some formatter changes, so it's difficult to stay on the pinned version any longer.
This disables the nightly-only branch coverage calculation and upgrades the Rust nightly version in the CI.
Relevant issues: