Upgrade FFI Dependency #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch upgrade the minimum version of FFI to be `1.13.1`. We recently run into segfaults with http-parser 1.2.1 (latest rubygems release) with ruby 2.7. Those segfaults were caused by the newly introduced Compacting GC but they are fixed in the 1.13.1 release of ffi. Issue on FFI: ffi/ffi#742 Fixing commit: ffi/ffi@6662bcc
makeable
reviewed
Jan 10, 2021
Collaborator
There was a problem hiding this comment.
https://rubygems.org/gems/ffi-compiler
Invalid version dependency for ffi-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upgrade the minimum version of FFI to be
1.13.1.We recently run into segfaults with http-parser 1.2.1 (latest rubygems release) with ruby 2.7.
Those segfaults were caused by the newly introduced Compacting GC but they are fixed in the 1.13.1 release of ffi.
Issue on FFI: ffi/ffi#742
Fixing commit: ffi/ffi@6662bcc