-
Notifications
You must be signed in to change notification settings - Fork 1
Updating Dependencies #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msamblanet
wants to merge
12
commits into
couralex:master
Choose a base branch
from
msamblanet:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated all dependencies - Updated configurations for compatibility - Removed code coverage (module was deprecated and not compatible with babel 7)
… repo (#2) - Implemented NYC for code coverage - Note: I was unable to test coveralls but it was implemented per the NYC documentation - Added files missed in last commit - Update package-lock to not list my private repository
Missed History Update
* Fix history nodes from 2.0.0 (missed save) * Remove some badges from readme * Add not-original notice to readme
Fix version number in package.json
- 2021-10-26: v2.0.1 - Fix repo links in package.json - Add badge to readme
zodman
suggested changes
Mar 14, 2023
| circularReference?: string; | ||
| search?: string; | ||
| iterateOverObject?: boolean; | ||
| skipIteration?: () => boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here missing the node argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project had very outdated dependencies which included both dev and runtime alerts from NPM. I have updated all of them to the latest version. In the process of doing so, I had to alter babel and mocha configurations to bring them up to date. I also had to replace the code coverage tool with NYC as the old one is deprecated and not compatible with the latest babel.
I was unable to test coveralls but it was configured as recommended by the NYC docs.
Unit tests pass and code coverage looks good.
I also bumped the version in package.json to 1.1.1 but of course have not made any effort to publish it.
Please let me know if I can be of any more assistance. If you are no longer maintaining this project, let me know so I can determine a good way to proceed as I plan to use this library in some of my work.