feat: component NumberInput storybook #4265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdostie
requested review from
FelixBlaisThon and
GermainBergeron
and removed request for
a team
gdostie
force-pushed
the
DS-41-connect-TextInput
branch
2 times, most recently
from
d62b4e9 to
c5a3ce9
Compare
gdostie
force-pushed
the
DS-41-connect-NumberInput
branch
from
f740ebc to
fb54cdd
Compare
FelixBlaisThon
approved these changes
Jan 5, 2026
gdostie
force-pushed
the
DS-41-connect-NumberInput
branch
from
fb54cdd to
b2681de
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive Storybook documentation for the NumberInput component and refactors the Figma connector to align with the prop handling patterns used by similar input components. The changes improve maintainability and provide better developer documentation.
Key Changes
- Added a new Storybook story file with comprehensive controls for the
NumberInputcomponent, including numeric validation props (min/max, allowNegative, allowDecimal) and formatting options (prefix, suffix, separators) - Refactored the Figma connector to extract
labelPropsfromwrapperProps, making it consistent with other input components like TextInput, Checkbox, Radio, and Switch
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/storybook/src/form/NumberInput.stories.tsx | New Storybook story with argTypes definitions and a demo showcasing NumberInput with optional icon support |
| packages/figma/src/NumberInput.figma.tsx | Refactored prop structure to align with other input components, moving labelProps to top level for cleaner prop mapping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request refactors the
NumberInputcomponent integration and adds a new Storybook demo. The main changes focus on simplifying prop handling in the Figma connector, ensuring correct exports, and enhancing documentation and testing through Storybook.Figma connector prop handling improvements:
packages/figma/src/NumberInput.figma.tsxto movelabelPropsout ofwrapperProps, simplifying how label, description, and error props are managed and mapped. Also, renamed several boolean controls for clarity (e.g.,Show Label→Asterisk,Show Description→Description, etc.).labelPropsforlabelandrequiredprops, reflecting the new structure.Component export and Storybook integration:
displayNametoNumberInputand ensured correct export frompackages/mantine/src/components/NumberInput/NumberInput.ts.NumberInputinpackages/storybook/src/form/NumberInput.stories.tsx, including controls for all major props, documentation, and a demo with an optional icon.Potential Breaking Changes
Acceptance Criteria